Filesystem labels #189
Merged
Filesystem labels #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 11, 2018
instead of physical partition number for the kernel cmdline root parameter. Signed-off-by: Theonlyzby <theonlyzby@gmail.com>
telphan
suggested changes
Apr 26, 2018
| cp /mnt/boot/cmdline.txt /mnt/boot/cmdline.txt.new | ||
| sed -i "s#mmcblk0p.#mmcblk0p$new_part_idx#g" /mnt/boot/cmdline.txt.new | ||
| sed -i "s#root=LABEL=[^ ]*#root=LABEL=$new_root_filesystem_label#g" /mnt/boot/cmdline.txt.new |
There was a problem hiding this comment.
This should match rooot=, so old version will updated properly to this verison.
There was a problem hiding this comment.
Can you please write what the sed line you think should be exactly?
There was a problem hiding this comment.
I think it should be something like this:
s#root=.* #root=LABEL=$new_root_filesystem_label#g
floion
force-pushed
the
filesystem_labels
branch
from
49bf37f
to
bb00f5d
Compare
use filesystem LABEL instead of physical partition number We now have the kernel cmdline root parameter using filesystem LABEL instead of physical partition number, so we need this hostapp update hook use LABEL too when doing the rootfs switch. Signed-off-by: Theonlyzby <theonlyzby@gmail.com>
floion
force-pushed
the
filesystem_labels
branch
from
bb00f5d
to
2b0bcfb
Compare
telphan
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.