Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure that config.json is always pretty printed #1300

Closed
afitzek opened this issue Nov 22, 2018 · 2 comments
Closed

Ensure that config.json is always pretty printed #1300

afitzek opened this issue Nov 22, 2018 · 2 comments
Assignees
@agherzan

Comments

@afitzek
Copy link
Contributor

afitzek commented Nov 22, 2018 •
edited
Loading

We decided to pretty print the config.json always, because customers did manually edit it, and stored non valid json, which corrupted the device. This should help them to keep a valid json.

Front logo Front conversations
@agherzan
Copy link
Contributor

@afitzek I think the main place where the config is generated is in the image maker as that injects the config. The OS should write/modify it with this pretty format.

agherzan pushed a commit that referenced this issue Nov 29, 2018
image-resin.bbclass: Fix config.json pretty format
6c5eead 
Fixes #1300

Change-type: patch
Signed-off-by: Andrei Gherzan <andrei@balena.io>
@agherzan agherzan mentioned this issue Nov 29, 2018
Merged
4 tasks
@ghost ghost assigned agherzan Nov 29, 2018
@ghost ghost added the flow/in-review label Nov 29, 2018
agherzan pushed a commit that referenced this issue Nov 29, 2018
image-resin.bbclass: Fix config.json pretty format
889d989 
Fixes #1300

Change-type: patch
Signed-off-by: Andrei Gherzan <andrei@balena.io>
This was referenced Nov 29, 2018
Closed
Merged
@agherzan
Copy link
Contributor

agherzan commented Dec 5, 2018

@afitzek All the components in the OS are now fixed to produce pretty formatted config.json. The only remaining one is the supervisor which has its own ticket: balena-os/balena-supervisor#816. Closing.

@agherzan agherzan closed this as completed Dec 5, 2018
@ghost ghost removed the flow/in-review label Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agherzan agherzan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agherzan @afitzek