Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host extensions support #1987

Merged
merged 15 commits into from
Oct 28, 2020
Merged

Host extensions support #1987

merged 15 commits into from
Oct 28, 2020

Conversation

alexgg
Copy link
Contributor

@alexgg alexgg commented Aug 7, 2020 •
edited
Loading

Contributor checklist

Reviewer Guidelines

  • When submitting a review, please pick:
    • 'Approve' if this change would be acceptable in the codebase (even if there are minor or cosmetic tweaks that could be improved).
    • 'Request Changes' if this change would not be acceptable in our codebase (e.g. bugs, changes that will make development harder in future, security/performance issues, etc).
    • 'Comment' if you don't feel you have enough information to decide either way (e.g. if you have major questions, or you don't understand the context of the change sufficiently to fully review yourself, but want to make a comment)

@alexgg alexgg requested a review from mtoman as a code owner August 7, 2020 11:12
@alexgg alexgg marked this pull request as draft August 7, 2020 11:12
@alexgg alexgg requested review from robertgzr and removed request for mtoman August 7, 2020 11:12
@alexgg alexgg force-pushed the alexgg/hostext branch 3 times, most recently from ff4b9f4 to f344f79 Compare August 10, 2020 18:11
@alexgg alexgg mentioned this pull request Aug 17, 2020
Closed
4 tasks
@alexgg alexgg force-pushed the alexgg/hostext branch 4 times, most recently from 9f6d9f7 to 0430f83 Compare August 25, 2020 09:49
@alexgg alexgg mentioned this pull request Aug 25, 2020
Closed
@alexgg alexgg force-pushed the alexgg/hostext branch 4 times, most recently from 8410b4d to 04ee4e9 Compare August 28, 2020 17:34
@alexgg alexgg linked an issue Aug 28, 2020 that may be closed by this pull request
Host extensions support #1984
Closed
@alexgg alexgg marked this pull request as ready for review August 28, 2020 17:35
@alexgg
Copy link
Contributor Author

alexgg commented Aug 28, 2020 •
edited
Loading

I have performed the following testing:

@alexgg alexgg force-pushed the alexgg/hostext branch 2 times, most recently from 82e437b to 659889c Compare September 7, 2020 14:22
@alexgg
Copy link
Contributor Author

alexgg commented Sep 7, 2020

@balena-ci retest

@alexgg
Copy link
Contributor Author

alexgg commented Sep 7, 2020

@resin-jenkins retest this please

1 similar comment
@alexgg
Copy link
Contributor Author

alexgg commented Sep 9, 2020

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Sep 10, 2020

@balena-ci retest

@alexgg
Copy link
Contributor Author

alexgg commented Sep 10, 2020

@resin-jenkins retest this please

mtoman
mtoman approved these changes Oct 20, 2020
View reviewed changes
Copy link
Contributor

@mtoman mtoman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@mtoman
Copy link
Contributor

mtoman commented Oct 20, 2020

@resin-jenkins retest this please

@robertgzr robertgzr mentioned this pull request Oct 21, 2020
Merged
@alexgg
Copy link
Contributor Author

alexgg commented Oct 21, 2020

@resin-jenkins retest this please

5 similar comments
@mtoman
Copy link
Contributor

mtoman commented Oct 21, 2020

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Oct 22, 2020

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Oct 22, 2020

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Oct 22, 2020

@resin-jenkins retest this please

@mtoman
Copy link
Contributor

mtoman commented Oct 26, 2020

@resin-jenkins retest this please

@alexgg
docker-disk: Add the host extension images to the data partition
cd44a94 
Host extension images contain extra content that is overlayed over the
root filesystem at boot.

This commits adds the default host extensions to the data partition
image, stores their repository tags in the /etc directory, and creates
the containers so that mobynit can mount the container filesystems on
boot.

Change-type: patch
Signed-off-by: Alex Gonzalez <alexg@balena.io>
@alexgg
resin-vars: Parse the HOSTEXT_IMAGES variable from config.json
761f517 
This variable allows the hostapp extensions updater script to update the
hostapp extensions in the system.

Change-type: patch
Signed-off-by: Alex Gonzalez <alexg@balena.io>
@alexgg
hostapp-extensions-update: Add host extensions update script
0fe293e 
This script triggers an installation or update of the hostapp extensions
in the system.

The list of hostapp extensions to install can either be passed to the
script or it will use the ones set in config.json or hostapp-extensions.conf
in that order.

Change-type: patch
Signed-off-by: Alex Gonzalez <alexg@balena.io>
@alexgg
packagegroup-resin: Add hostapp extensions update script
a03e5c9 
This commit adds the update-hostapp-extensions utility. It can be run
with:

 systemd-run update-hostapp-extensions -r

Change-type: patch
Signed-off-by: Alex Gonzalez <alexg@balena.io>
@alexgg
docs: Add host extensions documentation
1d33429 
Add a new section that described the host extensions functionality.

Fixes #1984

Change-type: minor
Changelog-entry: Add host extensions support
Signed-off-by: Alex Gonzalez <alexg@balena.io>
This was referenced Oct 27, 2020
Merged
Closed
@alexgg
Copy link
Contributor Author

alexgg commented Oct 27, 2020

@resin-jenkins retest this please

2 similar comments
@alexgg
Copy link
Contributor Author

alexgg commented Oct 28, 2020

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Oct 28, 2020

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Oct 28, 2020

@resin-jenkins retest this please

@alexgg
Copy link
Contributor Author

alexgg commented Oct 28, 2020

Testbot DUTs are having trouble and are being debugged (internal link https://www.flowdock.com/app/rulemotion/p-testbot/threads/uBhZdMU4zcdm2wzXDP7D1hMvg1Z)

Merging this commit as all DUTs have passed tests in several triggers, even though not all at the same time.

@alexgg alexgg merged commit 1d33429 into master Oct 28, 2020
@alexgg alexgg deleted the alexgg/hostext branch October 28, 2020 18:58
@alexgg
Copy link
Contributor Author

alexgg commented Oct 28, 2020

@balena-ci republish

@openedhardware
Copy link

@alexgg
Any update here?

@alexgg
Copy link
Contributor Author

alexgg commented Jan 21, 2021

hi @openedhardware still a work in progress, currently focusing on the updating process for these extra container images. We are working towards a release before the end of Q1.

@openedhardware
Copy link

Hi, @alexgg
Just wanted to check if you had a chance to release this?

@dremsol
Copy link
Contributor

dremsol commented Aug 12, 2021

@openedhardware as far as i know it has been pushed forward into a larger BalenaOS release. Don't expect it to be released any time soon as release dates have been postponed again and again. In the meantime, we have build our own OS and open-sourced it. If it helps you forward, please take a look at HawkeyeOS

@alexgg
Copy link
Contributor Author

alexgg commented Aug 13, 2021

hi @openedhardware unfortunately this improvement is still blocked on changes further up the product stack. We are currently working on the UI and supervisor modifications to allow for field updates of extensions.
@dremsol we have pushed back on estimations but I don't think there was any committed release date for this improvement, am I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtoman mtoman mtoman approved these changes

@floion floion Awaiting requested review from floion

@markcorbinuk markcorbinuk Awaiting requested review from markcorbinuk

@xginn8 xginn8 Awaiting requested review from xginn8

@robertgzr robertgzr Awaiting requested review from robertgzr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Host extensions support
6 participants
@alexgg @mtoman @openedhardware @dremsol @robertgzr @xginn8