Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(bal-number-input): German format with decimals #1400

Closed
1 task done
GinaBiondo-aperto opened this issue May 21, 2024 · 2 comments · Fixed by #1401
Closed
1 task done

🐛 fix(bal-number-input): German format with decimals #1400

GinaBiondo-aperto opened this issue May 21, 2024 · 2 comments · Fixed by #1401
Assignees
Labels
🐛 bug Something isn't working

Comments

@GinaBiondo-aperto
Copy link
Collaborator

Current Behavior

The decimals are added but the separator (',') is missing -> the value is no longer correct

Expected Behavior

The decimal separator should be added correct for all number formats to keep the correct value

Steps to Reproduce

use number input with german format and decimals

Version

16.1.0

Browsers

Firefox, Chrome, Safari, Microsoft Edge

Device

Mobile, Tablet, Desktop

Code Reproduction URL

No response

Additional Information

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@GinaBiondo-aperto GinaBiondo-aperto added the 🐛 bug Something isn't working label May 21, 2024
@hirsch88 hirsch88 changed the title fix(bal-number-input): German format with decimals 🐛 fix(bal-number-input): German format with decimals May 23, 2024
@hirsch88
Copy link
Member

/cib

Copy link
Contributor

Branch fix/issue-1400 created!

github-actions bot added a commit that referenced this issue May 23, 2024
hirsch88 added a commit that referenced this issue May 24, 2024
* Create PR for #1400

* fix(number-input): handle inputs for Germany

* chore: improve function name

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Gery Hirschfeld <gerhard.hirschfeld@baloise.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants