add Werkzeug version constraint to requirements #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Werkzeug >= 3.0 causes `ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/usr/local/lib/python3.8/dist-packages/werkzeug/urls.py)` in `mediator/brotab_mediator.py`. Flask 2.0.2's requirements specify only Werkzeug >= 2.0 but should also specify Werkzeug < 3.0. Unless and until this is fixed upstream, clients of Flask 2.0.2 must specify Werkzeug < 3.0 themselves to avoid this error.
|
Sharing here since this will be relevant until this PR is merged. If brotab is installed via pipx, you can just run this: . ~/.local/pipx/venvs/brotab/bin/activate
test $(pip list | awk '/Werkzeug/{ print $2 }' | cut -d. -f1) == 3 \
&& { pip uninstall werkzeug; pip install 'werkzeug<3'; echo updated; } \
|| echo already ok;Affecting #105, #37, #80, reply #43 (comment), mainly included already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brotab's mediator failed to run for me on Ubuntu 20.04 due to the following error:
ImportError: cannot import name 'url_quote' from 'werkzeug.urls' (/usr/local/lib/python3.8/dist-packages/werkzeug/urls.py)inmediator/brotab_mediator.py.This occurs with Werkzeug >= 3.0. Flask 2.0.2's should therefore specify Werkzeug < 3.0, but specifies only Werkzeug >= 2.0. Unless and until this is fixed upstream, clients of Flask 2.0.2 must specify Werkzeug < 3.0 themselves to avoid this error.