-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read property minify of null #4
Comments
Arrrrgh totally my bad, can you install the |
Sweet, thanks! |
The same error is happening here and I'm using version |
Hey pedronauck! Don't cry! 😄 |
Yes, it's the same file, and that's the error
I'm using Webpack 2! |
I think this is an issue with butternut itself rather than the module then, a similar issue has been reported in #123, as @estrattonbailey said, you need to remove the |
Hi. I had the same error:
The option that cause it is: 'process.env.NODE_ENV': JSON.stringify('production') |
Yup, agree with @gombek. It's breaking when Note: I'm currently minifying for both dev and prod, so it's not a simple mistake of not running Butternut in dev. |
Reopening for visibility, it's quite annoying that setting the production env does this, since butternut is intended to be run only with this one |
Hmm, just run into this, but it looks like relevant issue Rich-Harris/butternut#137 might be already fixed on master, but this plugin depends on @apercu Could you bump the dependency or maybe even make it |
Bumped all deps in |
Hey! Thanks for the lib.
I might be totally missing something, but when I installed from npm all I got was the
README.md
and thepackage.json
. It could be because npm inherits the.gitignore
config if it's available, so a blank.npmignore
should override it, in my experience.Happy to make a PR, but figured that you'd want to determine what else npm ignores and it's tiny tiny change 😛
UPDATE: I had manually compiled this lib locally and ran into errors, a la:
NODE_ENV=production webpack --config webpack.production.config.js -p /Users/eric.bailey/Sites/quanta-server/node_modules/butternut-webpack-plugin/node_modules/butternut/dist/butternut.cjs.js:1662 this.alternate.minify( code );
I just needed to remov the
-p
flag from the webpack command. My bad! Updating here in case it helps someone else.The text was updated successfully, but these errors were encountered: