Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] abbreviate multi-million credit values #30

Closed
slippycheeze opened this issue Dec 30, 2022 · 1 comment · Fixed by #33
Closed

[Feature] abbreviate multi-million credit values #30

slippycheeze opened this issue Dec 30, 2022 · 1 comment · Fixed by #33
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@slippycheeze
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Once I'm looking at an unsold value of 158,209,100 Cr. a lot of those numbers stop being really meaningful. The difference between 159,209,000 and 159,208,100 Cr. is quite small.

The extra detail makes it harder to understand, at a glance, what my balance is. (For me; I'm sure others don't experience the same.)

Describe the solution you'd like
I'd prefer to see "up to four significant digits" of value. So, for example:

Value             Display
1,234             1,234 Cr.
12,345            12.34k Cr.
123,456           123.5k Cr.
1,234,567         1,234k Cr.
12,345,678        12.35m Cr.
123,456,789       123.5m Cr.
1,234,567,890     1,235m Cr.

Round to nearest (.0 - .499 => 0, .5 - .999 => 1) seems to work best with that.

Describe alternatives you've considered
Any shortening would be fine, really, if it kept to three or four digits. Even five is probably fine to take in quickly, at a glance.

Additional context
I've used this before in displaying numbers where quick reference, at a glance comprehension was needed. It was the best way I found to manage that; people "get" four numbers fast, without getting overwhelmed, but it still shows the "right" amount of detail for humans at each stage.

@slippycheeze slippycheeze added the enhancement New feature or request label Dec 30, 2022
@Balvald Balvald self-assigned this Jan 1, 2023
@Balvald
Copy link
Owner

Balvald commented Jan 1, 2023

Currently have a version of this on dev using SI prefixes so far.

each consecutive line is x10 the previous one gives this

1 Cr.
10 Cr.
100 Cr.
1.000 KCr.
10.00 KCr.
100.0 KCr.
1.000 MCr.
10.00 MCr.
100.0 MCr.
1.000 GCr.
10.00 GCr.
100.0 GCr.
1.000 TCr.
10.00 TCr.
100.0 TCr.
1.000 PCr.
.
.
.

Probably should force myself and make an extra case where the decimal point is directy after the first digit to be a thousand seperator instead and use the lower SI prefix because I just realized 1.000 KCr. could be misinterpreted as being 1,000 KCr. while actually just being 1 KCr.

Balvald added a commit that referenced this issue Jan 1, 2023
fixing #32 and also reset button behaviour

doing the change I hinted at in my comment of #30
also proper rounding before value was just trunctated
though there are a few edgecases I've found that don't round properly

concerning #31 :
small fix where distance was always red if there wasn't even a position logged.
@Balvald Balvald added this to the v0.2.2 milestone Jan 2, 2023
Balvald added a commit that referenced this issue Jan 2, 2023
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line.

gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings.

increased version number v0.2.2

State on dev should now be:
Implemented:
#28 , #29, #30, #31
Fixed:
#32

Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this.

I want to do some additional testing regarding #28 before declaring this the next update.
Balvald added a commit that referenced this issue Jan 2, 2023
- New picture for preferences.
- Added missing option and updated renamed buttons
- Most new featues are options or slight changes to already existing features.

Now with the readme updated
I'll tag the rest of the issues as finished once I pull everything over.

closes #31 #30 #29 #28
@Balvald Balvald linked a pull request Jan 2, 2023 that will close this issue
Balvald added a commit that referenced this issue Jan 3, 2023
fixing #32 and also reset button behaviour

doing the change I hinted at in my comment of #30
also proper rounding before value was just trunctated
though there are a few edgecases I've found that don't round properly

concerning #31 :
small fix where distance was always red if there wasn't even a position logged.
Balvald added a commit that referenced this issue Jan 3, 2023
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line.

gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings.

increased version number v0.2.2

State on dev should now be:
Implemented:
#28 , #29, #30, #31
Fixed:
#32

Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this.

I want to do some additional testing regarding #28 before declaring this the next update.
Balvald added a commit that referenced this issue Jan 3, 2023
- New picture for preferences.
- Added missing option and updated renamed buttons
- Most new featues are options or slight changes to already existing features.

Now with the readme updated
I'll tag the rest of the issues as finished once I pull everything over.

closes #31 #30 #29 #28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants