Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow adding release notes to PR body #11

Merged
merged 1 commit into from
Apr 7, 2017
Merged

allow adding release notes to PR body #11

merged 1 commit into from
Apr 7, 2017

Conversation

balvig
Copy link
Owner

@balvig balvig commented Apr 6, 2017

Adding something like

_Release note: New search feature, please try it out_

to a PR's body, will use that instead of the title when composing release notes.
Could maybe skip the composing step if this turns out to be useful?

@balvig balvig merged commit ef09e7d into master Apr 7, 2017
@balvig balvig deleted the release_note branch April 7, 2017 06:34
@Knack
Copy link
Contributor

Knack commented Apr 10, 2017

@balvig Nice! So, if I want to mark a PR as "internal" to hide it in release notes... maybe writing it as a comment will work? Something like:

_Release note: # this is an internal refactoring of some class_

@balvig
Copy link
Owner Author

balvig commented Apr 10, 2017

@Knack hmm yes, or maybe in the future we leave out release notes for internal stuff? (and ignore PRs without release notes when posting to Slack) 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants