Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change start_params to None in call to GLM.fit_constrained used to get automatic priors #265

Merged
merged 4 commits into from
Nov 3, 2020

Conversation

tomicapretto
Copy link
Collaborator

@tomicapretto tomicapretto commented Nov 3, 2020

As mentioned in #230 (comment), using start_params equal to unconstrained MLE was causing the following error from statsmodels

ValueError: The first guess on the deviance function returned a nan. This could be a boundary problem and should be reported.

This error was also reported in #164

bambi/priors.py Outdated Show resolved Hide resolved
@aloctavodia
Copy link
Collaborator

Ready to merge after updating the changelog

@aloctavodia aloctavodia merged commit 512792c into bambinos:master Nov 3, 2020
@tomicapretto tomicapretto deleted the irls-param branch November 3, 2020 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants