Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when there are multiple calls with unnamed literals #88

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

tomicapretto
Copy link
Collaborator

Closes #87

Also removed the creation of sets when comparing values in the call_resolver.py module. It could lead to the wrong results when the same arguments were used but in a different order. Now the order matters in the comparison too.

@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #88 (9c41c38) into master (d36ef8d) will decrease coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   95.47%   95.46%   -0.02%     
==========================================
  Files          32       32              
  Lines        3583     3591       +8     
==========================================
+ Hits         3421     3428       +7     
- Misses        162      163       +1     
Impacted Files Coverage Δ
formulae/terms/call_resolver.py 91.91% <66.66%> (-0.63%) ⬇️
formulae/tests/test_design_matrices.py 98.66% <100.00%> (+0.01%) ⬆️
formulae/version.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomicapretto tomicapretto merged commit f0c360a into bambinos:master Feb 12, 2023
@tomicapretto tomicapretto deleted the fix_unhashable_lazy_value branch February 12, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formula spec fails when more than one function call
1 participant