Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15
Duplicate of #18 to run CI on this repo.
Description
The goal is to replace "com.app.any" in the Threads View by "UI Thread".
I wanted to usedetectCurrentAppBundleId
inpackages/android-performance-profiler/src/commands/cpu/getCpuStatsByProcess.ts
but it crashed the e2e-test because the app was not detected each time the function was called. I think it is because we close and open the app a lot during our tests.So I pass the bundle id in params. I don't know if this is the cleanest way.It was not working for big bundle id like
com.facebook.katana
or bigger. So, I used an other method that is to compareprocessId
andpid
. If these ids are the same, it is the main thread and we write "UI thread".Test plan
I manually tested the result on the reporter and it works fine!
I also ran tests and updated snapshot.
I don't know how I can manually test
flipper-plugin-android-performance-profiler
so if you know how to do it I can try.