Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Yoda configurable timeout duration #2307

Merged
merged 10 commits into from
Jul 31, 2020
Merged

Yoda configurable timeout duration #2307

merged 10 commits into from
Jul 31, 2020

Conversation

Benzbeeb
Copy link
Contributor

Fixed: #2258

Implementation details

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

If this PR doesn't need to be merged into v1.0.6 please remove this option:

  • The pull request has been cherry-picked to rc/1.0.6

@Benzbeeb Benzbeeb requested review from sorawit and taobun July 24, 2020 09:20
@render
Copy link

render bot commented Jul 24, 2020

Your Render PR Server URL is https://d3n-scan-pr-2307.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bsdaftc1do6mke3t4h6g.

Nattharat Wiriyakulnan added 2 commits July 31, 2020 14:17
@Benzbeeb Benzbeeb requested review from sorawit and taobun July 31, 2020 07:55
taobun
taobun suggested changes Jul 31, 2020
View reviewed changes
chain/yoda/executor/docker_test.go Outdated Show resolved Hide resolved
chain/yoda/executor/docker_test.go Outdated Show resolved Hide resolved
chain/yoda/executor/executor.go Outdated Show resolved Hide resolved
@Benzbeeb Benzbeeb requested a review from taobun July 31, 2020 08:15
@Benzbeeb Benzbeeb merged commit ca88d5e into master Jul 31, 2020
@Benzbeeb Benzbeeb deleted the yoda-timeout-config branch July 31, 2020 09:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@taobun taobun taobun approved these changes

@sorawit sorawit sorawit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Yoda configurable timeout duration
3 participants
@Benzbeeb @sorawit @taobun