Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

Scan: Block index mobile #2312

Merged
merged 5 commits into from
Jul 26, 2020
Merged

Scan: Block index mobile #2312

merged 5 commits into from
Jul 26, 2020

Conversation

prin-r
Copy link
Member

@prin-r prin-r commented Jul 26, 2020

Fixed: #2262

Implementation details

  • Implement layout for mobile

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@prin-r prin-r requested review from evilpeach and pzshine July 26, 2020 04:14
@render
Copy link

render bot commented Jul 26, 2020

Your Render PR Server URL is https://d3n-scan-pr-2312.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-bseg6egl1r19glf5esdg.

evilpeach
evilpeach suggested changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
As the image above, let's show the card's loading state properly.

@prin-r prin-r requested a review from evilpeach July 26, 2020 09:15
evilpeach
evilpeach approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@evilpeach evilpeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@evilpeach evilpeach merged commit 4596193 into master Jul 26, 2020
@evilpeach evilpeach deleted the block-index-mobile branch July 26, 2020 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@evilpeach evilpeach evilpeach approved these changes

@pzshine pzshine Awaiting requested review from pzshine

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block Index Page (mobile)
2 participants
@prin-r @evilpeach