Skip to content
This repository has been archived by the owner on Nov 16, 2022. It is now read-only.

owasm: Remove unnecessary traits in ext and add more docs #2362

Merged
merged 2 commits into from
Aug 3, 2020

Conversation

sorawit
Copy link
Member

@sorawit sorawit commented Aug 1, 2020

Implementation details

This PR removes unnecessary trait requirements, including Clone and num::NumCast, from owasm utility functions. Also adds some more doc comments.

Please ensure the following requirements are met before submitting a pull request:

  • The pull request is targeted against the correct target branch
  • The pull request is linked to an issue with appropriate discussion and an accepted design OR is linked to a spec that describes the work.
  • The pull request includes a description of the implementation/work done in detail.
  • The pull request includes any and all appropriate unit/integration tests
  • You have added a relevant changelog entry to CHANGELOG_UNRELEASED.md
  • You have re-reviewed the files affected by the pull request (e.g. using the Files changed tab in the Github PR explorer)

@render
Copy link

render bot commented Aug 1, 2020

@taobun
Copy link
Member

taobun commented Aug 3, 2020

OEI spec has been changed @Benzbeeb please update oracle script files too!

@sorawit sorawit merged commit b0bd4cf into master Aug 3, 2020
@sorawit sorawit deleted the remove-unnecessary-traits-from-owasm-ext branch August 3, 2020 06:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants