Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to access inherited property for JS class #26

Closed
wants to merge 1 commit into from

Conversation

victorteokw
Copy link
Contributor

This commit add support for accessing inherited property.
Unit test added, too.

Also,
this commit add a launching screen, have it being able to support iPhone 5 screen.
And the iOS demo get a much nicer background color.

@bang590
Copy link
Owner

bang590 commented Jun 8, 2015

@cheunghy Seems that you make -getProp: and -setProp:forKey support the original property, but this two APIs should only use for custom property in JS, the original property already has API to get and set, I think self.setTitle("t") is better than self.setProp_forKey("t", "title").

@victorteokw
Copy link
Contributor Author

Oh, I see.

@victorteokw
Copy link
Contributor Author

So you may close it since this PR is not valid anymore.

@bang590
Copy link
Owner

bang590 commented Jun 8, 2015

@cheunghy thanks

@bang590 bang590 closed this Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants