feat: add axios request test #14
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/bangumi-fe/frontend/5NxBnxTzXcULS2e2kTU5oHeBS3cb |
|
打包之后浏览器会报 |
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
============================================
- Coverage 100.00% 87.06% -12.94%
============================================
Files 3 5 +2
Lines 58 116 +58
Branches 3 7 +4
============================================
+ Hits 58 101 +43
- Misses 0 14 +14
- Partials 0 1 +1
Continue to review full report at Codecov.
|
|
|
||
| // 异常拦截处理器 | ||
| const errorHandler = (error:any) => { | ||
| console.log(error) |
There was a problem hiding this comment.
| console.log(error) |
console.log 好像不太必要
There was a problem hiding this comment.
请求异常先log一下，以后再补异常处理
|
bgm38，如果可以的话麻烦补个单测吗？不行的话我来补也可以，当作后来 PR 的一个例子。 |
没写过单测，不知道怎么写b38 |
| const api = { | ||
| getCharacterDetail: '/v0/characters/' | ||
| } |
There was a problem hiding this comment.
个人觉得可以不用这个 api，直接写到方法上就好。
There was a problem hiding this comment.
有的时候可以复用，路径多了也方便管理
There was a problem hiding this comment.
又发邮件警报了 我删掉了🤣
Co-authored-by: Qingyu Deng <i@ayase-lab.com>
Co-authored-by: Qingyu Deng <i@ayase-lab.com>
|
Merged, thanks |
Deploying with
|
| Latest commit: |
9b94e66
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a7ade082.bangumi-frontend.pages.dev |
| Branch Preview URL: | https://pr-627-storybook.bangumi-frontend.pages.dev |
加了个axios请求库，写法很土，环境变量是放在对应workplace下面吗
两个问题
我不知道怎么改