feat: add API for PersonCollect #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everpcpc
changed the title
trim21
reviewed
May 16, 2024
trim21
reviewed
May 16, 2024
everpcpc
force-pushed
the
feat-person-collects
branch
from
fe41ca9
to
a6db777
Compare
|
看样子是OK了 |
everpcpc
force-pushed
the
feat-person-collects
branch
4 times, most recently
from
75b9dc2
to
41cb287
Compare
everpcpc
force-pushed
the
feat-person-collects
branch
from
41cb287
to
09fb430
Compare
everpcpc
force-pushed
the
feat-person-collects
branch
3 times, most recently
from
dc7eede
to
f57df13
Compare
everpcpc
force-pushed
the
feat-person-collects
branch
from
f57df13
to
e05ede6
Compare
everpcpc
force-pushed
the
feat-person-collects
branch
from
e05ede6
to
c0cc25b
Compare
trim21
reviewed
May 18, 2024
web/routes.go
Outdated
| v0.GET("/characters/:id", characterHandler.Get) | ||
| v0.GET("/characters/:id/image", characterHandler.GetImage) | ||
| v0.GET("/characters/:id/subjects", characterHandler.GetRelatedSubjects) | ||
| v0.GET("/characters/:id/persons", characterHandler.GetRelatedPersons) | ||
| v0.POST("/characters/:id/collect", characterHandler.CollectCharacter, mw.NeedLogin) | ||
| v0.DELETE("/characters/:id/collect", characterHandler.UncollectCharacter, mw.NeedLogin) |
There was a problem hiding this comment.
因为条目收藏的 URL 里没有 subjects 字样，不太好加别的，只能跟 index 收藏的 URL 风格统一了 TAT
trim21
reviewed
May 18, 2024
trim21
reviewed
May 18, 2024
|
需要哪几个表的权限 |
|
应该只需要 |
|
增删改吗 |
|
只有增删查，这个表应该没有改的操作 |
everpcpc
force-pushed
the
feat-person-collects
branch
4 times, most recently
from
2e4d456
to
4a3ffee
Compare
everpcpc
force-pushed
the
feat-person-collects
branch
from
4a3ffee
to
a6a23ac
Compare
|
要不先把删的API屏蔽掉吧，后面改好了再启用。先把增和改的上线 |
|
这种没有改操作的也要软删除吗 TAT |
|
trim21
reviewed
May 22, 2024
trim21
reviewed
May 22, 2024
|
测试挂了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.