-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename RubyVM::DebugInspector to DebugInspector and add support for truffleruby #37
Conversation
eregon
commented
Jan 24, 2023
- Fixes Renaming the module from RubyVM::DebugInspector to DebugInspector (required for TruffleRuby support) #36
- Also update CI.
5b01957
to
2671a4b
Compare
831d3eb
to
a444abc
Compare
This is now green and ready for review. cc @RobinDaugherty |
Ping, I'd love a review of this. |
@RobinDaugherty Ping :) |
Ping |
@eregon i gave you write access to this repo |
Thank you! |
75bdd3f
to
0253b0c
Compare
…ruffleruby * Fixes banister#36 * Also update CI.
0253b0c
to
cfdf85c
Compare
I should also say for clarity I'm happy to maintain this gem. @banister I would like to make a release with this merged, let's say version 1.2.0, if that sounds OK. I could do the release on GitHub, but we'd also need to push the gem. |
Hi @eregon i added you as a gem owner, let me know if you got the link. It's a very shit UI, i'm actually shocked how terrible the rubygems UI is. Anyway, hopefully you got it. |
@banister I haven't received the email (yet?) unfortunately. |
the email worked, LMK how it goes
…On Tue, Dec 5, 2023 at 3:56 AM Benoit Daloze ***@***.***> wrote:
@banister <https://github.com/banister> I haven't received the email
(yet?) unfortunately.
Do you see me in the list at
https://rubygems.org/gems/debug_inspector/owners ?
If you need it, my email is eregontp (gmail).
—
Reply to this email directly, view it on GitHub
<#37 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAEI3SO6G7W66INCADGFOLYHYTGLAVCNFSM6AAAAAAUFGTSACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMZZGM3TOMJXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks! That worked. |