This repository has been archived by the owner on Jan 26, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6
Track dividend accruals/payouts/reinvestments #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The library's exponential backoff always starts with a 1s delay, which is too frequent for the Flex Query API
Required using Sequence types instead of List in a couple places, for covariance (really, it seems like we should use Sequence almost everywhere—but that can be a separate change). Leaving IBKR untouched for the moment because we are literally only downloading trades; activity statements will need separate support.
Thanks, Tests™!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7.
Activity
class whichTrade
inherits fromActivity
ReplaceTradeFlags
with something nicerSupport mutual funds (seeVMFXX
in Vanguard)realizedBasis…
to consider dividend payouts