Change delegates to weak references #21
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpotlightViewController
contained a strong reference to aSpotlightTransitionController
, which in turn had a strong reference to theSpotlightViewController
through thedelegate
variable.This caused a reference cycle that prevented
SpotlightViewController
s from being deallocated, leaking memory.By changing the
delegate
variable inSpotlightTransitionControllerDelegate
to a weak variable, this retain cycle is prevented. I changed thedelegate
inSpotlightViewControllerDelegate
to a weak variable as well, as this is common practice for delegates.