Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for record pill sheet history to non active pill sheet last pill number #619

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jun 9, 2022

Abstract

アクティブなピルシートよりも過去のピルシートの最後のピル番号に対して服用した場合にafterLastTakenNumberの表記が0になってしまう問題を回避する

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai marked this pull request as ready for review June 9, 2022 23:00
@bannzai bannzai merged commit 0680c84 into main Jun 10, 2022
@bannzai bannzai deleted the bugfix/view/pill_sheet_history branch June 10, 2022 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant