PillSheetを削除 #710
Merged
PillSheetを削除 #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PillSheet.idは作っていれたいが(服用履歴部分の修正と前提が大きく変わってしまうため)、PilllSheet.idを含めてインスタンス化した場合は既存テストケースに影響することになりどちらも修正量が大きくなるので一旦見送る。理想的な構造にしたくなった時に考え直す |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
PillSheetGroupができてPillSheetをFiretoreに保存する必要がなくなったので削除する。PillSheetGroup.pillSheetsには引き続き保存する
Why
Links
Checked