Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyboardToolbarの追加 #729

Merged
merged 20 commits into from
Nov 29, 2022
Merged

KeyboardToolbarの追加 #729

merged 20 commits into from
Nov 29, 2022

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Nov 29, 2022 •
edited
Loading

Abstract

  • KeyboardToolbarの追加。日記と予定画面をKeyboardToolbarを使って置き換える。ついでにStackだったものをColumnにした
  • 初期設定が完了しないバグに気付いたので修正
  • 日記でバグがあったので修正

Why

Links

Checked

  • Analyticsのログを入れたか
  • Navigator.of(context).pop() の後にContextを使用したメソッドを実行していない
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai changed the base branch from main to base/refactor/app/full-scrach November 29, 2022 13:47
@bannzai bannzai merged commit d28fb5b into base/refactor/app/full-scrach Nov 29, 2022
@bannzai bannzai deleted the add/view/keyboard_toolbar branch November 29, 2022 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bannzai