Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix device orientation #736

Merged
merged 1 commit into from
Jan 1, 2023
Merged

Fix device orientation #736

merged 1 commit into from
Jan 1, 2023

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Dec 24, 2022

Abstract

デバイスの向きを固定にする。横向きだと画面崩れが起きると言う問い合わせで気づいた。意図してないのでロックする

Why

Links

Checked

  • Analyticsのログを入れたか
  • Navigator.of(context).pop() の後にContextを使用したメソッドを実行していない
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた
  • リリースノートを追加した

@bannzai bannzai merged commit ff32e4b into main Jan 1, 2023
@bannzai bannzai deleted the fix/setting/device_orientation branch January 1, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant