Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

初期設定からメインストリームの画面に遷移する間での色々を修正 #742

Merged
merged 31 commits into from
Jan 19, 2023
Merged

初期設定からメインストリームの画面に遷移する間での色々を修正 #742

merged 31 commits into from
Jan 19, 2023
+295 −312

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Jan 19, 2023 •
edited
Loading

Abstract

  • サインイン後にメインの画面に遷移しなかったので修正
  • ↑の修正をしている時にテストがこけてしまうので根本的に組み直した
  • InitialSettingOrAppPageType はfunctionに切り出して単体テストできるように
    • それ以上下位のWidgetがProviderを使うと、その分のMockまで用意する必要がある
  • RootPage -> UserSetupPage -> InitialSettingOrApp と初期セットアップの処理ごとにWidgetを分離。ツリーの下に行くことで前提を増やして考え事を少なくする

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた

@bannzai
Redirect to main stream
949f5a7
@bannzai
Fix auth stream subscription
eb6954e
@bannzai
Remove unnecessary provider
9ce3750
@bannzai
Remove unnecessary import
34aff2c
@bannzai
Fill userProvider
5895c40
@bannzai
Fix provider
9203ed5
@bannzai
fix root test
b4985ac
@bannzai
WIP fix shared preference provider
58dd668
@bannzai
Revert "WIP fix shared preference provider"
61b993c 
This reverts commit 58dd668.
@bannzai
Fix prepare sharedPreferences provider
99343ff
@bannzai
Fix define timing
e4d0fb0
@bannzai
Use mustSharedPrefenceProvider
88f999a
@bannzai
Remove unnecessary import
cc729da
@bannzai
Rename to RootPage
22c039d
@bannzai
Remove unnecessary import
6e4bd7b
@bannzai
Rename to firebaseUserID
3afbc12
@bannzai
Revert "Rename to firebaseUserID"
19705e0 
This reverts commit 3afbc12.
@bannzai
Rename
220c1b5
@bannzai
Move
9ded4bd
@bannzai
Fix RootPage
5ae59af
@bannzai
Refactor decided screen type
9932e31
@bannzai
Rewrite test case
44b5af8
@bannzai
Keep SSoT
9dd2bd4
@bannzai
Fix login flow
6a6a87c
bannzai
bannzai commented Jan 19, 2023
View reviewed changes
lib/provider/database.dart Outdated Show resolved Hide resolved
@bannzai bannzai changed the title Redirect to main stream 初期設定からメインストリームの画面に遷移する間での色々を修正 Jan 19, 2023
@bannzai bannzai merged commit 5f5385c into main Jan 19, 2023
@bannzai bannzai deleted the bugfix/function/sign_in branch January 19, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bannzai