Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store review timing #821

Merged
merged 18 commits into from
Apr 16, 2023
Merged

Fix store review timing #821

merged 18 commits into from
Apr 16, 2023

Conversation

bannzai
Copy link
Owner

@bannzai bannzai commented Apr 16, 2023

Abstract

Store Review のタイミングを変更した

ついで

  • 諸々の起動時のモーダル表示をHomeに移動した
  • boolSharedPreferenceProviderじゃない方が都合が良いと思ったので書き換えた

Why

Links

Checked

  • Analyticsのログを入れたか
  • 境界値に対してのUnitTestを書いた
  • パターン分岐が発生するWidgetに対してWidgetTestを書いた

@bannzai
Copy link
Owner Author

bannzai commented Apr 16, 2023

@bannzai bannzai merged commit 5d3e875 into main Apr 16, 2023
@bannzai bannzai deleted the add/view/pre_store_review branch April 16, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant