Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HIS): introduction to the HIS checker #52

Merged
merged 4 commits into from
Oct 26, 2023
Merged

Conversation

AfonsoSantos96
Copy link
Member

This is the introduction PR to add the HIS metric checker to the bao-ci workflow.
The HIS metrics define recommended thresholds for a set of key code quality metrics (explicit in afterward PRs).
This PR still does not include the checker script itself but prepares the CI structure to eventually run it.

Type of change

  • feat: introduces a new functionality
    • Logical unit: his_checker

Checklist:

  • The changes generate no new warnings when building the project. If so, I have justified above.
  • I have run the CI checkers before submitting the PR to avoid unnecessary runs of the workflow.

Signed-off-by: Afonso Santos <afomms@gmail.com>
Signed-off-by: Afonso Santos <afomms@gmail.com>
Copy link
Member

@danielRep danielRep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tried with bao-partitioner. LGTM, however you still need to commit the his_checker.py with x permissions.

@AfonsoSantos96
Copy link
Member Author

Just tried with bao-partitioner. LGTM, however you still need to commit the his_checker.py with x permissions.

Sure! Just changed the permissions in the last commit

his_checker.py Outdated Show resolved Hide resolved
@josecm
Copy link
Member

josecm commented Oct 13, 2023

@AfonsoSantos96 can you open a draft PR for the wip/his-metrics branch, so that you can discuss the overall state of the metrics there?

Signed-off-by: Afonso Santos <afomms@gmail.com>
Signed-off-by: Afonso Santos <afomms@gmail.com>
@josecm josecm merged commit 2c77837 into wip/his-metrics Oct 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants