Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a decent alternative for /etc/conf.d/snapper #42

Closed
wants to merge 1 commit into from
Closed

Use a decent alternative for /etc/conf.d/snapper #42

wants to merge 1 commit into from

Conversation

DevWurm
Copy link

@DevWurm DevWurm commented Jun 3, 2017

Use a decent fallback if /etc/conf.d/snapper does not exist, by considering all available snapper configurations.

On some installations (like mine on ubuntu) the /etc/conf.d/snapper file doesn't exist. By using all available configurations in the snapper config file folder, the tool also works on those systems.

Use a decent fallback if `/etc/conf.d/snapper` does not exist, by considering all available snapper configurations.
@wesbarnett
Copy link
Collaborator

I didn't realize it was not in that location on other distributions. It looks like for Ubuntu it is at /etc/sysconfig/snapper: http://manpages.ubuntu.com/manpages/trusty/man8/snapper.8.html

The problem of looking in the directory is that someone can have a configuration that they no longer use.I have several configurations that I created for snapper but have stopped using simply by modifying the global configuration file.

@DevWurm
Copy link
Author

DevWurm commented Jun 3, 2017

So in my case it's not even there and i have no idea were it could be :/

@wesbarnett
Copy link
Collaborator

What does your local manpage say for snapper? Perhaps the location has changed.

@DevWurm
Copy link
Author

DevWurm commented Jun 3, 2017

It says /etc/sysconfig/snapper but I dont even have the directory /etc/sysconfig. The man page may be outdated

@wesbarnett
Copy link
Collaborator

I believe the default that upstream provides is /etc/sysconfig/snapper and that Arch Linux changes this to /etc/conf.d/snapper. How about locate snapper?

@wesbarnett
Copy link
Collaborator

I'm thinking the right way to fix this is to not include every possible location of the configuration file, but instead use the upstream's location by default and then at installation somehow provide an option to specify a different location.

@DevWurm
Copy link
Author

DevWurm commented Jun 3, 2017

Just desktop files and icons:

/usr/share/app-install/desktop/repsnapper:repsnapper.desktop
/usr/share/app-install/icons/repsnapper.svg
/var/lib/app-info/icons/ubuntu-xenial-universe/64x64/repsnapper_repsnapper.png

@wesbarnett
Copy link
Collaborator

Not even the executable is found (i.e. /usr/bin/snapper)?

@wesbarnett
Copy link
Collaborator

cat /etc/cron.daily/snapper

@DevWurm
Copy link
Author

DevWurm commented Jun 3, 2017

Oh there it is!
Its /etc/default/snapper on Ubuntu.
You were right: It was referenced in /etc/cron.daily/snapper

@wesbarnett
Copy link
Collaborator

I'll make this easier to set in the script and available via the Makefile.

@wesbarnett wesbarnett closed this Jun 3, 2017
wesbarnett added a commit that referenced this pull request Jun 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants