Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with big amount of files #6

Closed
asannikov opened this issue Jul 8, 2020 · 5 comments
Closed

Does not work with big amount of files #6

asannikov opened this issue Jul 8, 2020 · 5 comments
Milestone

Comments

@asannikov
Copy link

I'm looping big ~10k files using this call for each iteration:
fileInfos := et.ExtractMetadata(file)

After the ~7k loops the program hangs. I debugged a bit and found that it hangs in https://github.com/barasher/go-exiftool/blob/master/exiftool.go#L121 on the line: fmt.Fprintln(e.stdin, executeArg)

i tried to run the same file in 10k loops. Works fine. With the different files does not work.

Can it be that e.stdin is overflowed?

@barasher
Copy link
Owner

barasher commented Jul 9, 2020

I'll try to reproduce the bug at home, this weekend.
I'll have some holidays starting next week, for a month, so I'm unfortunately not sure that it will be fixed "quickly" :(

@asannikov
Copy link
Author

@barasher, thank you for your quick response.
This is not a problem, i'll add another interesting statistic in the meanwhile. have a good holidays!

@asannikov
Copy link
Author

@barasher i solved that issue in the MR #9
it does nothing with big amount of files. The problem is in the overflowed token buffer.

@barasher
Copy link
Owner

barasher commented Aug 9, 2020

@asannikov , thanks a lot !
I'm back tuesday, I'll have a look and gladly merge it then.

@barasher
Copy link
Owner

Feature added in commit 8b99a50, released in v1.2.0 tag
Once more, thank you for your contribution @asannikov !
Could you please check if this version still fix the bug you encountered ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants