This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
aubuf overruns on startup #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the reader thread starts late, the buffer should not be filled over the min value.
|
@sreimers Please could you restart the tests? |
|
Done |
|
Looks like they are still failing. The branch detection (PR checkout) looks good at a first look: |
|
I can't reproduce the failure in the github action on my dev host. |
|
Okay, found how to reproduce this: |
cspiel1
force-pushed
the
aubuf_overrun_on_startup
branch
from
2a44f3c
to
c03763b
Compare
wip-sync
pushed a commit
to NetBSD/pkgsrc-wip
that referenced
this pull request
Jul 18, 2022
Partial changelog: == [v2.5.0] - 2022-07-01 == What's Changed * ci/build: fix macOS openssl path by @sreimers in baresip/rem#59 * vidmix: use C11 mutex by @alfredh in baresip/rem#58 * aubuf: fix possible data race warning by @cspiel1 in baresip/rem#61 * aubuf: C11 mutex by @alfredh in baresip/rem#62 * ajb: C11 mutex by @alfredh in baresip/rem#63 * aubuf: correct ajb reset on frame drop and on underruns by @cspiel1 in baresip/rem#64 * aubuf: better support for different put/get ptime by @cspiel1 in baresip/rem#65 --- == [v2.4.0] - 2022-06-01 === What's Changed * aubuf overruns on startup by @cspiel1 in baresip/rem#44 * h265: move from rem to re by @alfredh in baresip/rem#45 * aubuf: do not drop frames if max size was not set by @cspiel1 in baresip/rem#47 * h264: move from rem to re by @alfredh in baresip/rem#46 * vidmix win32 fixes by @sreimers in baresip/rem#49 * aumix: use new libre thread api by @sreimers in baresip/rem#48 * aubuf/ajb: fix possible null pointer deref by @sreimers in baresip/rem#50 * Fade in on underrun and reset ajb by @cspiel1 in baresip/rem#51 * aubuf: add null pointer checks by @cspiel1 in baresip/rem#52 * auconv: add auconv_to_float() by @alfredh in baresip/rem#53 * audio: add optional decoding buffer by @cspiel1 in baresip/rem#54
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For multicast listeners there had been overruns at startup of a stream because of late start of player thread. In order to make aubuf independent from start time relation between write and read threads a started flag was added.
Relates to baresip/retest#64