This repository has been archived by the owner on Feb 16, 2023. It is now read-only.
aubuf: prevent faulty timestamps #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are applications where a useful timestamp is not available. E.g. if audio files are read and decoded. Then audio frames are written to aubuf with `timestamp == 0`. In such cases a partial read with `aubuf_read_auframe()` set a wrong timestamp to the rest frame.
For partial read timestamps are changed for the rest frames. This works only if the timestamps are already set correctly during writing. This commit handles also the case correct if the application provides timestamps and the first frame has timestamp zero and the first read is partial.
|
So from my side this PR is ready for merge. The new retests should check the correct behavior and this PR fixes a bug for partial reading. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the application does not set the timestamps of the pushed audio frames, then during a partial read faulty timestamps had been set.
--> This seems to be a simple fix. But is wrong for a partial read if the application sets correct timestamps and the first frame has timestamp zero.
The following commits sets timestamps automatically for pushed audio frames, if not given by the application.
This baresip/retest#104 adds unit tests for partial read with automatic timestamps.