Extend stack type #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
barnjamin
commented
Feb 1, 2023
•
barnjamin
commented
- add immediate arg positions in the case of errors
- for labels I need their names
- for ops that may branch I need the target labels names
- need to know op names for each line
- a list of ops that can terminate a program (err, return, etc.)
- no-op line numbers
- args ranges + arg type info
- comments ranges
barnjamin
force-pushed
the
extend-stack-type
branch
from
90cb1a7
to
5a81044
Compare
barnjamin
force-pushed
the
extend-stack-type
branch
3 times, most recently
from
6281d99
to
0444f35
Compare
barnjamin
force-pushed
the
extend-stack-type
branch
from
0444f35
to
8edd3fc
Compare
…ckType at assembly time
jannotti
reviewed
Feb 2, 2023
cmd/opdoc/opdoc.go
Outdated
| @@ -28,13 +28,13 @@ import ( | |||
| "github.com/algorand/go-algorand/protocol" | |||
| ) | |||
|
|
|||
| var docVersion = 8 | |||
| var latestVersion = 8 | |||
There was a problem hiding this comment.
If we're going to generate all versions, including the one after the current consensus version (which I think is correct). We can go back to a world that does not have this variable at all, and uses the value in logic.LogicVersion.
If we generate all these langspecs, we'll have to change the website to pick up the right one to show. (Maybe it should show them all somehow, but the "main" one should be the current mainnet's consensus value.
barnjamin
force-pushed
the
extend-stack-type
branch
from
1bd4c52
to
0a6d6af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.