Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Set individual logging intervals per URL #24

Open
Romfrosk opened this issue Jun 15, 2020 · 5 comments
Open

Feature Request: Set individual logging intervals per URL #24

Romfrosk opened this issue Jun 15, 2020 · 5 comments

Comments

@Romfrosk
Copy link

Hi.

I'd love to be able to log at different intervals to URLs.

BrewSpy can handle every 5m
Brewfather can handle every 15m
Google can probably handle every minute if not more often.

@noahbaron
Copy link
Collaborator

noahbaron commented Jun 19, 2020 via email

@Romfrosk
Copy link
Author

Yes. They do mention that 15m is the lowest value.

I will test to set it at 5 minutes and see if it just skips the values coming in too quick, or if it also blocks those coming in every 15m.

Can't test until my beer has been bottled though.

@tmack8001
Copy link
Contributor

I believe from when I was looking at reworking the custom urls in nodered that yes BrewFather does ignore anything that comes in sooner than the 15m window, not sure of the specifics off the top of my head.

Overall this is a much welcomed addition. I'll look to see if I can resurrect my flow that had something similar to this, but missing edge case testing.

@tmack8001
Copy link
Contributor

This is what the UI looked like on my branch (not complete). It would store properties in a map data structure for each of the "cloud logging providers" created (frequency, url, enabled and name) I think were all specific to the provider being updated.

Screenshot_20210125-202841.png

@tmack8001
Copy link
Contributor

For instance here I have brewfather (not named) and google sheets (though have the same time interval set for both right now).
image

When I built this I also thought we should make it so the user can't "delete" the google sheets entry, but rather just disable it thus the "enabled" toggle and an uneditable Default Google Sheets entry.

image

Not sure when I'll have time to come back to this and learn more about NodeRED to make sure I catch all the edge cases that might happen, but who knows might try to finish this off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants