-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pending state is fragile to CI/builder failures #121
Comments
I don't know if |
In my (probably controversial) opinion, if we run |
That could probably be arranged in the (probably inevitable) fork. I think things like closing and reopening should clean. I'm okay with retry not cleaning. |
Why is a fork inevitable? |
In general,
This is exactly what Also note that
As I said above, that's what |
@barosl Aha! I'll close this, then. I suspect the issue is related to our buildbot problems, rather than things in homu itself. We were also using |
Don't stop processing the queue when tree is closed <!-- Reviewable:start --> This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/homu/121) <!-- Reviewable:end -->
In cases where homu sets a pull to
pending
, but something goes wrong with the builders or CI systems, it's easy for homu to end up stuck but with nothing going on. Worse, the Synchronize button doesn't help, and issuing aretry
appears to do nothing, either.What's the right thing to do here? We've run into this a bit when either Travis CI or linode (where we host buildbot) or GitHub goes wonky under a DDOS, as we start having lost messages, aborted builders w/o any status messages, etc.
Today, I manually restart all the services on the server, go through GH and re-deliver messages, and close PRs as necessary to get things going again. It would be great if there were either:
approved
state@homu reset
?) to clear thepending
back toapproved
cc @Manishearth for more feedback/ideas and @metajack @edunham since it's been an ugly week or two :-)
The text was updated successfully, but these errors were encountered: