Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master #4

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Master #4

merged 2 commits into from
Aug 26, 2020

Conversation

barry-jin
Copy link
Owner

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

liuzh47 and others added 2 commits August 26, 2020 02:16
@liuzh47
fix typo (#1317)
39ec921 
Co-authored-by: Ubuntu <ubuntu@ip-10-20-2-34.ec2.internal>
@liuzh47
fix typo (#1318)
970318d 
Co-authored-by: Ubuntu <ubuntu@ip-10-20-2-34.ec2.internal>
@barry-jin barry-jin merged commit 2a9b3ba into barry-jin:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barry-jin @liuzh47