Update ViewCollector.php for StringBladeCompiler #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is to support my StringBladeCompiler plugin. Without the change the debugbar generates an error, "realpath () expects parameter 1 to be a valid path, object given" This is because the path is an object when using the StringBladeCompler plugin instead of a template file path. Thanks.
|
Forgot to mention this should only apply to the Laravel 5 version with StringBladeCompiler 3. The plugin is a replacement/extension to the default Laravel view. |
|
+1 |
|
Is this going to be merged? I really want to use these two packages together but can't at the moment. |
barryvdh
added a commit
that referenced
this pull request
Feb 18, 2016
Update ViewCollector.php for StringBladeCompiler
|
Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to support my StringBladeCompiler plugin.
Without the change the debugbar generates an error, "realpath () expects parameter 1 to be a valid path, object given"
This is because the path is an object when using the StringBladeCompler plugin instead of a template file path.
Thanks.