Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use patterns for model_locations #921

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Ability to use patterns for model_locations #921

merged 1 commit into from
Apr 22, 2020

Conversation

4n70w4
Copy link
Contributor

@4n70w4 4n70w4 commented Apr 21, 2020

Example: app/Services/*/Models

@mfn
Copy link
Collaborator

mfn commented Apr 21, 2020

Thanks, can you describe your use-case a bit?

@4n70w4
Copy link
Contributor Author

4n70w4 commented Apr 21, 2020

@mfn case: process models from all services/modules by one rule.

config/ide-helper.php

    'model_locations' => array(
        'app/Services/*/Models',
    ),
tree app/Services/ -d -L 1
app/Services/
|-- AAAService
|-- ApplicationServices
|-- BBBService
|-- CCCService
|-- ConfirmationService
|-- DDDService
|-- EEEService
|-- FFFService
|-- GeoReferenceService
|-- GlobalPatchService
|-- HelperService
|-- KeycloakServices
|-- OOOService
|-- PPPService
|-- QQQService
|-- RRRService
|-- ShortlinkService
`-- TradingPlatformService

18 directories

Example: app/Services/*/Models
Copy link
Collaborator

@mfn mfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can you please:

  • expand the docs in the config to mention globs are not supported
  • same for the command option itself (getOptions)

Thanks!

@mfn
Copy link
Collaborator

mfn commented Apr 21, 2020

are not supported

#fail 🤦‍♂️

Of course I meant "are now supported" 😄

@barryvdh barryvdh merged commit a233d5b into barryvdh:master Apr 22, 2020
@barryvdh
Copy link
Owner

Thanks!

@4n70w4
Copy link
Contributor Author

4n70w4 commented Apr 22, 2020

@mfn If you tell me, then I don’t understand what it is and where it is.

mfn added a commit to mfn/laravel-ide-helper that referenced this pull request Apr 22, 2020
@mfn
Copy link
Collaborator

mfn commented Apr 22, 2020

@4n70w4 nevermind, already made a PR myself => #925

barryvdh pushed a commit that referenced this pull request Apr 22, 2020
fatihdirikman added a commit to fatihdirikman/Laravel-IDE-Helper that referenced this pull request Jan 7, 2022
renaforsberg824 added a commit to renaforsberg824/ide-helper-laravel-developer that referenced this pull request Oct 5, 2022
lisadeloach63 added a commit to lisadeloach63/ide-helper-reso-laravel that referenced this pull request Oct 7, 2022
sadafrangian3 pushed a commit to sadafrangian3/ide-helper-laravel that referenced this pull request Oct 18, 2022
smile1130 added a commit to smile1130/laravel-IDE that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants