Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a cache API #1310

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Add a cache API #1310

merged 2 commits into from
Apr 2, 2024

Conversation

bartfeenstra
Copy link
Owner

@bartfeenstra bartfeenstra commented Feb 24, 2024

To do

  • ensure the versions mentioned in the deprecations are accurate
  • Create follow-ups to remove deprecated functionality
    • Refactor DocumentationServer to receive a BinaryFileCache
    • Refactor LocalizerRepository to receive a BinaryFileCache

@bartfeenstra bartfeenstra added enhancement New feature or request BC break Breaks backwards compatibility with existing integrations labels Feb 24, 2024
betty/cache.py Outdated Show resolved Hide resolved
betty/cache.py Outdated Show resolved Hide resolved
betty/asyncio.py Outdated Show resolved Hide resolved
Copy link

Uploaded Betty for commit b32b030. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit a7b44a5. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

betty/app/__init__.py Outdated Show resolved Hide resolved
betty/asyncio.py Outdated Show resolved Hide resolved
@bartfeenstra bartfeenstra force-pushed the cache-api-2 branch 2 times, most recently from 26a84a1 to b1a7e93 Compare February 25, 2024 22:33
betty/cache.py Outdated Show resolved Hide resolved
Copy link

Uploaded Betty for commit 26a84a1. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit b1a7e93. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit 42ea04b. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Mar 5, 2024

Uploaded Betty for commit 286457e. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Mar 5, 2024

Uploaded Betty for commit a937c9b. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 99.42529% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.52%. Comparing base (7e33437) to head (47cd63f).

Files Patch % Lines
betty/wikipedia.py 95.23% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.3.x    #1310      +/-   ##
==========================================
+ Coverage   92.29%   92.52%   +0.22%     
==========================================
  Files          82       85       +3     
  Lines        9190     9444     +254     
==========================================
+ Hits         8482     8738     +256     
+ Misses        708      706       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 5, 2024

Uploaded Betty for commit d91c05a. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

betty/app/__init__.py Outdated Show resolved Hide resolved
betty/cache.py Outdated Show resolved Hide resolved
betty/tests/conftest.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 5, 2024

Uploaded Betty for commit 6fae2f5. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

betty/tests/__init__.py Outdated Show resolved Hide resolved
betty/tests/__init__.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Mar 5, 2024

Uploaded Betty for commit bf42a16. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit b6a6814. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit b167843. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra removed the BC break Breaks backwards compatibility with existing integrations label Mar 23, 2024
Copy link

Uploaded Betty for commit db10331. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit c61f7f7. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit b4ccc38. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

Uploaded Betty for commit d689c90. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 2, 2024

Uploaded Betty for commit c4f0e2a. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

github-actions bot commented Apr 2, 2024

Uploaded Betty for commit d67c8db. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra marked this pull request as ready for review April 2, 2024 14:02
Copy link

github-actions bot commented Apr 2, 2024

Uploaded Betty for commit 6561e7d. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra marked this pull request as draft April 2, 2024 15:19
@bartfeenstra bartfeenstra marked this pull request as ready for review April 2, 2024 15:25
Copy link

github-actions bot commented Apr 2, 2024

Uploaded Betty for commit 47cd63f. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

@bartfeenstra bartfeenstra merged commit 5e5f3e6 into 0.3.x Apr 2, 2024
11 checks passed
@bartfeenstra bartfeenstra deleted the cache-api-2 branch April 2, 2024 15:36
@bartfeenstra bartfeenstra modified the milestones: 0.3.x, 0.3.3 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant