Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a segfault in the Graphical User Interface #1420

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix a segfault in the Graphical User Interface #1420

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions betty/extension/cotton_candy/gui.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,12 @@ def __init__(self, app: App, color: _ColorConfiguration, *args: Any, **kwargs: A
self._color.on_change(self.repaint)
self.setFixedHeight(24)
self.setFixedWidth(24)
self._swatch = QRect(self.rect())

def paintEvent(self, a0: QPaintEvent | None) -> None:
try:
painter = QPainter(self)
except TypeError:
# Work around a so far inexplicable bug where this method would be called, but `self` would no longer refer
# to a valid QObject.
return
swatch = QRect(self.rect())
painter.fillRect(swatch, QBrush(QColor.fromString(self._color.hex)))
painter.drawRect(swatch)
painter = QPainter(self)
painter.fillRect(self._swatch, QBrush(QColor.fromString(self._color.hex)))
painter.drawRect(self._swatch)


class _ColorConfigurationWidget(LocalizedObject, QWidget):
Expand Down
Loading