Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure favicon.ico always exists (to satisfy eager clients) #1591

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

bartfeenstra
Copy link
Owner

This fixes #1404

Follow-ups

  • Port to 0.3.x?

@bartfeenstra bartfeenstra added the enhancement New feature or request label Jun 21, 2024
@bartfeenstra bartfeenstra marked this pull request as ready for review June 21, 2024 19:15
Copy link

Uploaded Betty for commit 7d73c1f. You can download it, test it, and post your feedback in a comment to this pull request 💕

These downloads will stop working when the pull request is closed.

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.59%. Comparing base (8b38ebd) to head (7d73c1f).
Report is 315 commits behind head on 0.4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##            0.4.x    #1591   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files         199      199           
  Lines       19016    19017    +1     
  Branches     3618     3618           
=======================================
+ Hits        18179    18180    +1     
  Misses        571      571           
  Partials      266      266           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bartfeenstra bartfeenstra merged commit 000ca94 into 0.4.x Jun 21, 2024
11 checks passed
@bartfeenstra bartfeenstra deleted the favicon branch June 21, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename betty.ico to favicon.ico
1 participant