Add null check to verifyIfObjectsMatch #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @baruchvlz , kindly look into PR. It will help the cypress community in a way. |
|
Thanks. As far as I know, the default value is only used if the passed argument is |
|
Tried to update it based on your feedback. Let me know what you think. |
baruchvlz
approved these changes
Jul 28, 2020
|
@baruchvlz do we have a new release yet? thanks. |
|
@abhinaba-ghosh @tobloef I'm really sorry y'all, completely slipped my mind to publish the package. v1.8.0 should be available now. |
|
Thanks a lot. 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing some trouble for me. To give some context, I encountered this in my Cypress tests using cypress-react-selector, which is dependent on resq. I'm not sure exactly what is causing the argument to be null, but this seemed like the easiest fix.