fix default notification positioning

resolves
base-apps · Jan 23, 2017 · d30e8b4 · d30e8b4
1 parent 3dbaebe
commit d30e8b4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/js/angular/components/notification/notification.js b/js/angular/components/notification/notification.js
@@ -86,7 +86,7 @@
     return directive;
 
     function link(scope, element, attrs, controller) {
-      scope.position = scope.position ? scope.position.split(' ').join('-') : 'top-right';
+      scope.position = scope.position ? scope.position.split(' ').join('-') : 'default-position';
 
       scope.$on("$destroy", function() {
         BaseAppsApi.unsubscribe(attrs.id);
@@ -242,7 +242,7 @@
       }
 
       function postLink(scope, element, attrs, controller) {
-        scope.position = attrs.position ? attrs.position.split(' ').join('-') : 'top-right';
+        scope.position = attrs.position ? attrs.position.split(' ').join('-') : 'default-position';
 
         var animationIn = attrs.animationIn || 'fadeIn';
         var animationOut = attrs.animationOut || 'fadeOut';

diff --git a/scss/components/_notification.scss b/scss/components/_notification.scss
@@ -183,13 +183,14 @@ $notification-icon-align: top !default;
 
     position: fixed !important;
 
-    &.top-right     { @include notification-layout(right, top); }
-    &.top-left      { @include notification-layout(left, top); }
-    &.top-middle    { @include notification-layout(middle, top); }
+    &.default-position  { @include notification-layout(); }
+    &.top-right         { @include notification-layout(right, top); }
+    &.top-left          { @include notification-layout(left, top); }
+    &.top-middle        { @include notification-layout(middle, top); }
 
-    &.bottom-right  { @include notification-layout(right, bottom); }
-    &.bottom-left   { @include notification-layout(left, bottom); }
-    &.bottom-middle { @include notification-layout(middle, bottom); }
+    &.bottom-right      { @include notification-layout(right, bottom); }
+    &.bottom-left       { @include notification-layout(left, bottom); }
+    &.bottom-middle     { @include notification-layout(middle, bottom); }
 
     &.success   { @include notification-style($success-color) }
     &.warning   { @include notification-style($warning-color) }
@@ -200,13 +201,14 @@ $notification-icon-align: top !default;
   .notification-container {
     @include notification-container;
 
-    &.top-right     { @include notification-layout(right, top); }
-    &.top-left      { @include notification-layout(left, top); }
-    &.top-middle    { @include notification-layout(middle, top); }
+    &.default-position  { @include notification-layout(); }
+    &.top-right         { @include notification-layout(right, top); }
+    &.top-left          { @include notification-layout(left, top); }
+    &.top-middle        { @include notification-layout(middle, top); }
 
-    &.bottom-right  { @include notification-layout(right, bottom); }
-    &.bottom-left   { @include notification-layout(left, bottom); }
-    &.bottom-middle { @include notification-layout(middle, bottom); }
+    &.bottom-right      { @include notification-layout(right, bottom); }
+    &.bottom-left       { @include notification-layout(left, bottom); }
+    &.bottom-middle     { @include notification-layout(middle, bottom); }
   }
 
   .notification-icon {