Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading Symbol Directives #38

Closed
soumak77 opened this issue Aug 6, 2016 · 5 comments
Closed

Loading Symbol Directives #38

soumak77 opened this issue Aug 6, 2016 · 5 comments

Comments

@soumak77
Copy link
Contributor

soumak77 commented Aug 6, 2016

Create a set of loading symbol directives that make it easy to change the style and color of the loading symbol. The loading symbols from SpinKit would be a good place to start. All the loading symbols are created with SCSS and will plug in nicely with this framework.

@soumak77
Copy link
Contributor Author

soumak77 commented Aug 6, 2016

One thing I noticed is that SpinKit does not provide SCSS mixins, so changing the size of the loading symbol is not supported. I've created an issue to track adding of SCSS mixins to the library (tobiasahlin/SpinKit#120). Once that is implemented it should be fairly straight forward to get the directives created.

@soumak77 soumak77 added this to the 1.3 Release milestone Aug 10, 2016
@soumak77
Copy link
Contributor Author

I finished rewriting the spinkit library to use mixins (tobiasahlin/SpinKit#121). There appears to already be a library though that is attempting to do what I want: https://github.com/Urigo/angular-spinkit. I'll contact the author to see if they are willing to update their library to be responsive.

@soumak77
Copy link
Contributor Author

On second thought, since the integration is so simple, I would prefer to fully integrate the library into the framework. This way the spinners can be easily colored and sized similar to everything else in the framework.

Anyone else have input on this?

@tolyo
Copy link
Contributor

tolyo commented Aug 11, 2016

@soumak77 Integrate into the library for fewer dependencies.

@soumak77
Copy link
Contributor Author

Done. I've included the modified source code from SpinKit with the framework until tobiasahlin/SpinKit#121 is accepted and a new version is published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants