Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git clone with --recurse-submodules #889

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

xiaohui-zhangxh
Copy link
Contributor

When git added some submodules, docker build will failed due to submodules' code is missing.

@xiaohui-zhangxh
Copy link
Contributor Author

When git added some submodules, docker build will failed due to submodules' code is missing.

I don't know why this CI test all failed

@djmb djmb merged commit e871d34 into basecamp:main Aug 26, 2024
1 of 7 checks passed
@djmb
Copy link
Collaborator

djmb commented Aug 26, 2024

Fixed the tests in 9ccfe20

@fabiendv
Copy link

@djmb Thank you. Is it possible to init only 1 submodule ?

E.g. if only one submodule is required to build the image

@xiaohui-zhangxh
Copy link
Contributor Author

It's strange that you added more than one submodules but only one is required. Whatever, you can try pre-build hook to remove unnecessary submodules

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants