Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for tables #36

Closed
orf opened this issue Oct 19, 2015 · 14 comments
Closed

Support for tables #36

orf opened this issue Oct 19, 2015 · 14 comments

Comments

@orf
Copy link

orf commented Oct 19, 2015

It seems there is no support for Tables in trix? Is this on the roadmap or something that has been intentionally left out?

@askoxyz
Copy link

askoxyz commented Oct 19, 2015

I'd also be interested in tables support.

@jeremy jeremy mentioned this issue Oct 19, 2015
12 tasks
@jeremy
Copy link
Member

jeremy commented Oct 19, 2015

→ added to Roadmap Questions list!

@jeremy jeremy closed this as completed Oct 19, 2015
@eidge
Copy link

eidge commented Jan 13, 2016

Would like to have this one as well!

@bentremblay
Copy link

If this can be of any help to anyone, I wrote a post on the concepts behind how we've worked around Trix's document model and implemented table support by simply treating tables as attachments.

@javan
Copy link
Contributor

javan commented Aug 23, 2018

I’m about to go real meta here, but the core idea is that we use Trix to edit individual cells’ content. Trix within Trix!

Finally, when clicking Update, we just loop through each cell to get its content from Trix, package the table in a TrixAttachment and insert it into the editor.

That's super cool, @bentremblay. Thanks for sharing!

@sledge909
Copy link

@bentremblay any chance of sharing the code relating to table support?

@bentremblay
Copy link

@sledge909 I definitely intend to write a follow-up article with some code examples and maybe put something up on GitHub too. Just can't say exactly when...

@MrRio
Copy link

MrRio commented Oct 1, 2018

@bentremblay That'd be great..

@thewebsitedev
Copy link

@bentremblay Any update on this? thanks!

@timofejvoronkov
Copy link

Hello! Any update on this? thanks )

@nitsujri
Copy link

nitsujri commented Nov 6, 2019

@bentremblay Would love to see if there's anyway you could share any code. Even if it's not fully pulled out yet.

@jondkinney
Copy link

@bentremblay thanks for the awesome article. We're thinking of using Trix and attachments to do some in-line commenting and "suggesting edits" type features. Table support has come up as a potential requirement as well for this project. Do you have any code you can share regarding your tables as attachments implementation? Thanks!!

@bentremblay
Copy link

@jondkinney Sorry for the late reply. I'm currently working on the next version of our app and will be looking in the near future at re-implementing support for tables, particularly in the new context of Rails Action Text.

I'm aiming at sharing some of that new code instead of the existing implementation. At this point, the time I'll spend extracting and packaging the existing code for sharing is time I won't be spending on the rewrite.

@warnes
Copy link

warnes commented Apr 16, 2021

@bentremblay Any news on sharing code for table support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests