Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for python 3.10 and 3.11, dropping 3.7 #291

Merged
merged 6 commits into from
May 18, 2023

Conversation

bolasim
Copy link
Collaborator

@bolasim bolasim commented May 18, 2023

Here are the new sets of images that need to be generated:

vscode in /workspaces/truss on bola/add-support-for-newer-python-version-310-311
$ ./bin/generate_base_images.py --push --dry-run --job-type all --live-reload both --use-gpu both --python-version all --skip-login
Building image :: baseten/truss-server-base:3.8-gpu-reload-v0.4.6
Building image :: baseten/truss-server-base:3.8-reload-v0.4.6
Building image :: baseten/truss-server-base:3.8-gpu-v0.4.6
Building image :: baseten/truss-server-base:3.8-v0.4.6
Building image :: baseten/truss-server-base:3.9-gpu-reload-v0.4.6
Building image :: baseten/truss-server-base:3.9-reload-v0.4.6
Building image :: baseten/truss-server-base:3.9-gpu-v0.4.6
Building image :: baseten/truss-server-base:3.9-v0.4.6
Building image :: baseten/truss-server-base:3.10-gpu-reload-v0.4.6
Building image :: baseten/truss-server-base:3.10-reload-v0.4.6
Building image :: baseten/truss-server-base:3.10-gpu-v0.4.6
Building image :: baseten/truss-server-base:3.10-v0.4.6
Building image :: baseten/truss-server-base:3.11-gpu-reload-v0.4.6
Building image :: baseten/truss-server-base:3.11-reload-v0.4.6
Building image :: baseten/truss-server-base:3.11-gpu-v0.4.6
Building image :: baseten/truss-server-base:3.11-v0.4.6
Building image :: baseten/truss-training-base:3.8-gpu-reload-v0.4.6
Building image :: baseten/truss-training-base:3.8-reload-v0.4.6
Building image :: baseten/truss-training-base:3.8-gpu-v0.4.6
Building image :: baseten/truss-training-base:3.8-v0.4.6
Building image :: baseten/truss-training-base:3.9-gpu-reload-v0.4.6
Building image :: baseten/truss-training-base:3.9-reload-v0.4.6
Building image :: baseten/truss-training-base:3.9-gpu-v0.4.6
Building image :: baseten/truss-training-base:3.9-v0.4.6
Building image :: baseten/truss-training-base:3.10-gpu-reload-v0.4.6
Building image :: baseten/truss-training-base:3.10-reload-v0.4.6
Building image :: baseten/truss-training-base:3.10-gpu-v0.4.6
Building image :: baseten/truss-training-base:3.10-v0.4.6
Building image :: baseten/truss-training-base:3.11-gpu-reload-v0.4.6
Building image :: baseten/truss-training-base:3.11-reload-v0.4.6
Building image :: baseten/truss-training-base:3.11-gpu-v0.4.6
Building image :: baseten/truss-training-base:3.11-v0.4.6

@joostinyi
Copy link
Collaborator

I think this needs version bump to to trigger the base image generation GH action, also needs to account for 3.11 in base.Dockerfile.jinja fail_fast block

@bolasim
Copy link
Collaborator Author

bolasim commented May 18, 2023

@joostinyi I added what I think is a fix. Can you please re-review?

Copy link
Collaborator

@joostinyi joostinyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit on the regex

truss/templates/base.Dockerfile.jinja Outdated Show resolved Hide resolved
@bolasim bolasim force-pushed the bola/add-support-for-newer-python-version-310-311 branch from 5084504 to 6006202 Compare May 18, 2023 17:13
@bolasim bolasim requested a review from joostinyi May 18, 2023 17:14
@bolasim bolasim merged commit 7fb720e into main May 18, 2023
@bolasim bolasim deleted the bola/add-support-for-newer-python-version-310-311 branch May 18, 2023 22:00
@bolasim bolasim self-assigned this Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants