Fixing postprocess() interface in README template. #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marius-baseten
approved these changes
May 30, 2024
|
The change looks good, but you need to update some tests |
auto-merge was automatically disabled
August 7, 2024 21:02
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 What
This PR corrects a small interface definition in the README template. Instead of referencing
postprocess(request)we now referencepostprocess(response)in alignment with egtruss.model_wrapper(see code).💻 How
Editing a jinja template to correct some templated text.
🔬 Testing
Looked for details on where this template might be used, but couldn't find any!
git grepthroughout the codebase only surfacedreadme_generatorandtruss_handlereferences. Maybe this is auto-generated for user trusses?