Improve error discovery when the LSP process cannot be started

robertrossmann · robertrossmann · commit 11dbe4910cdc · 2019-09-02T11:32:37.000+02:00
diff --git a/vscode-client/src/extension.ts b/vscode-client/src/extension.ts
@@ -29,7 +29,7 @@ export async function activate(context: ExtensionContext) {
 
     start(context, command, explainshellEndpoint, highlightParsingErrors)
   } catch (error) {
-    handleMissingExecutable()
+    handleStartError(error)
   }
 }
 
@@ -93,7 +93,9 @@ function handleOutdatedExecutable() {
   window.showErrorMessage(message, { modal: false })
 }
 
-function handleMissingExecutable() {
-  const message = `Can't find bash-language-server on your PATH. Please install it using "npm i -g bash-language-server".`
+function handleStartError(error: Error) {
+  const message =
+    'Unable to start bash-language-server, did you install it? Open DevTools for additional details.'
+  console.error(error)
   window.showErrorMessage(message, { modal: false })
 }

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ export async function activate(context: ExtensionContext) {`
`29`	`29`
`30`	`30`	`start(context, command, explainshellEndpoint, highlightParsingErrors)`
`31`	`31`	`} catch (error) {`
`32`		`- handleMissingExecutable()`
	`32`	`+ handleStartError(error)`
`33`	`33`	`}`
`34`	`34`	`}`
`35`	`35`
`@@ -93,7 +93,9 @@ function handleOutdatedExecutable() {`
`93`	`93`	`window.showErrorMessage(message, { modal: false })`
`94`	`94`	`}`
`95`	`95`
`96`		`-function handleMissingExecutable() {`
`97`		- const message = `Can't find bash-language-server on your PATH. Please install it using "npm i -g bash-language-server".`
	`96`	`+function handleStartError(error: Error) {`
	`97`	`+ const message =`
	`98`	`+ 'Unable to start bash-language-server, did you install it? Open DevTools for additional details.'`
	`99`	`+ console.error(error)`
`98`	`100`	`window.showErrorMessage(message, { modal: false })`
`99`	`101`	`}`