Fix remove expired on read race #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an expired entry is found in they keydir on a read operation, the code immediately and unconditionally deletes it. But the entry could have been updated since the read, and we could end up deleting a new value. This commit changes the delete to be conditional. It will succeed only if we are deleting exactly the same entry we found. If a newer entry is found instead, the get operation is retried.
|
+1 860eb0d |
borshop
added a commit
that referenced
this pull request
Sep 12, 2014
Fix remove expired on read race Reviewed-by: slfritchie
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an expired entry is found in they keydir on a read operation, the
code immediately and unconditionally deletes it. But the entry could
have been updated since the read, and we could end up deleting a new
value.
This commit changes the delete to be conditional. It will succeed only
if we are deleting exactly the same entry we found. If a newer entry is
found instead, the get operation is retried.
This addresses #191