Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support rebar binary in system #46

Merged
merged 1 commit into from Nov 8, 2012

Conversation

Projects
None yet
3 participants
Contributor

iwamatsu commented Aug 2, 2012

This provides the binary of rebar. However, I think that using the rebar binary
installed in the system in many cases.
By this change, when rebar is already installed in system, this change that rebar
of System use installed. And when not provided, use the binary provide in source.

Signed-off-by: Nobuhiro Iwamatsu iwamatsu@nigauri.org

@iwamatsu iwamatsu Support rebar binary in system
This provides the binary of rebar. However, I think that using the rebar binary
installed in the system in many cases.
By this change, when rebar is already installed in system, this change that rebar
of System use installed. And when not provided, use the binary provide in source.

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
3cc4002

I'd appreciate having handled it that way. Since recently, I've been doing it for my projects as well. However, one can put it a bit more concisely:

    REBAR := $(shell which rebar || echo ./rebar)
    ...
Owner

iwamatsu replied Aug 19, 2012

I think that your method is briefer and that it is good, too
I thought that the following was also good as other methods.

REBAR := ./rebar

@slfritchie slfritchie pushed a commit that referenced this pull request Nov 8, 2012

Scott Lystig Fritchie Merge pull request #46 from iwamatsu/master
Support rebar binary in system
de235ed

@slfritchie slfritchie merged commit de235ed into basho:master Nov 8, 2012

Contributor

slfritchie commented Nov 8, 2012

Hi, all. Many apologies for the long delay, Iwamatsu-san. Merging today, many thanks!

-Scott

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment